Did you have to replace the inner PinLock visor or just the pins that hold as.
After taking a close look at mine, I would expect the pins to last only so long. But I would also think that it is just the pins that need to be replaced.
My helmet actually came with a spare set.
I just replace the Pinlock insert, the pins stay on the visor. What wears out is the rubberized seal on the insert. If the pins fall out while you're manhandling the visor on, you can buy replacement pins.
However, if your visor gets all scratched up, you'll have to replace the visor with one that has Pinlock pins, if you want to continue using them.
Tell you the truth, although the Pinlock does work well, they are kinda pricey and after going through a few inserts, I don't use them anymore. I just crack open the bottom of the visor to vent some air in and it gets rid of the fogging.
Face might get a bit wet in the rain, but meh....