How does one become a motorcycle instructor? I can ride a motorcycle but I'm not like, a maestro or anything. I presume you don't necessarily have to be
It helps to be proficient at riding, but IMO, the #1 skill to be an instructor is to be able to communicate effectively. The school will train you on the curriculum and how to teach adults.
#2 skill is being an effective coach. This is how to observe someone carrying out the exercises, spot what they are doing wrong, identify the root cause and explain it in a way that they can fix their mistakes.
#3 skill is personality management. You're going to get all types of students - from over-talkers, to over-thinkers, anxiety-disorders, over-confidence, criers, blamers, etc. You'll need to adapt your teaching style and your people skills to reach all these different personalities. I've seen too many instructors only teach one way, and fail to reach people who relate to and learn differently.
You've heard the saying, "Those who can't do, teach"?
Unfortunately, being a good rider is actually the least important skill. Adults learn by listening, doing and watching. You can explain the exercise and get them to do it, but if they can't see someone else doing it correctly, they are missing a key element of learning. In my experience, a lot of motorcycle instructors actually aren't very good riders. When I taught in Ontario, I estimate that 30-40% of the instructors probably didn't feel confident enough to demo the exercises and IMO, half of them would struggle to pass the M1X test with a perfect score.
Demoing has never been a hard requirement of any school I've taught at. I've asked the chief instructor why it wasn't mandatory and he said that if demoing was a hard requirement, then the pool of instructor would probably shrink by 70%. I think this is unfortunate.
That said, if you do become an instructor, spend as much time as you can demoing and practicing. The tiny school bikes are excellent platforms to test and push the limits of your skills.
And if you drop the bike, just blame it on a student...